Forum Discussion

Altera_Forum's avatar
Altera_Forum
Icon for Honored Contributor rankHonored Contributor
17 years ago

bug in altera_avalon_tse.c

I just found this in altera_avalon_tse.c (Q8.0SP1):

/* map the PHY with PHY in profile */

is_phy_in_profile = 0;

for(i = 0; i < phy_profile_count; i++) {

/* if PHY match with PHY in profile */

if((pphy_profiles->oui == oui) || (pphy_profiles->model_number == model_number))

i will be much better with && instead of ||

{

pphy->pphy_profile = pphy_profiles;

/* phy found, add it to phy_list */

tse_dprintf(2, "info : phy %s found at phy address 0x%02x of mac group[%d]\n", pphy_profiles->name, phyadd, mac_group_index);

is_phy_in_profile = 1;

break;

}

}

Cheers,

Marc
No RepliesBe the first to reply